diff --git a/src/protocols/LinuxDMABUF.cpp b/src/protocols/LinuxDMABUF.cpp index 8bf95c139..a949d6a18 100644 --- a/src/protocols/LinuxDMABUF.cpp +++ b/src/protocols/LinuxDMABUF.cpp @@ -120,7 +120,7 @@ bool CLinuxDMABuffer::good() { return m_buffer && m_buffer->good(); } -CLinuxDMABUFParamsResource::CLinuxDMABUFParamsResource(SP resource_) : m_resource(resource_) { +CLinuxDMABUFParamsResource::CLinuxDMABUFParamsResource(UP&& resource_) : m_resource(std::move(resource_)) { if UNLIKELY (!good()) return; @@ -215,7 +215,7 @@ void CLinuxDMABUFParamsResource::create(uint32_t id) { LOGM(LOG, " | plane {}: mod {} fd {} stride {} offset {}", i, m_attrs->modifier, m_attrs->fds[i], m_attrs->strides[i], m_attrs->offsets[i]); } - auto buf = PROTO::linuxDma->m_buffers.emplace_back(makeShared(id, m_resource->client(), *m_attrs)); + auto& buf = PROTO::linuxDma->m_buffers.emplace_back(makeUnique(id, m_resource->client(), *m_attrs)); if UNLIKELY (!buf->good() || !buf->m_buffer->m_success) { m_resource->sendFailed(); @@ -224,7 +224,7 @@ void CLinuxDMABUFParamsResource::create(uint32_t id) { } if (!id) - m_resource->sendCreated(PROTO::linuxDma->m_buffers.back()->m_buffer->m_resource->getResource()); + m_resource->sendCreated(buf->m_buffer->m_resource->getResource()); m_createdBuffer = buf; } @@ -291,7 +291,8 @@ bool CLinuxDMABUFParamsResource::verify() { return true; } -CLinuxDMABUFFeedbackResource::CLinuxDMABUFFeedbackResource(SP resource_, SP surface_) : m_surface(surface_), m_resource(resource_) { +CLinuxDMABUFFeedbackResource::CLinuxDMABUFFeedbackResource(UP&& resource_, SP surface_) : + m_surface(surface_), m_resource(std::move(resource_)) { if UNLIKELY (!good()) return; @@ -342,7 +343,7 @@ void CLinuxDMABUFFeedbackResource::sendDefaultFeedback() { m_lastFeedbackWasScanout = false; } -CLinuxDMABUFResource::CLinuxDMABUFResource(SP resource_) : m_resource(resource_) { +CLinuxDMABUFResource::CLinuxDMABUFResource(UP&& resource_) : m_resource(std::move(resource_)) { if UNLIKELY (!good()) return; @@ -350,8 +351,8 @@ CLinuxDMABUFResource::CLinuxDMABUFResource(SP resource_) : m_ m_resource->setDestroy([this](CZwpLinuxDmabufV1* r) { PROTO::linuxDma->destroyResource(this); }); m_resource->setGetDefaultFeedback([](CZwpLinuxDmabufV1* r, uint32_t id) { - const auto RESOURCE = - PROTO::linuxDma->m_feedbacks.emplace_back(makeShared(makeShared(r->client(), r->version(), id), nullptr)); + const auto& RESOURCE = + PROTO::linuxDma->m_feedbacks.emplace_back(makeUnique(makeUnique(r->client(), r->version(), id), nullptr)); if UNLIKELY (!RESOURCE->good()) { r->noMemory(); @@ -361,8 +362,8 @@ CLinuxDMABUFResource::CLinuxDMABUFResource(SP resource_) : m_ }); m_resource->setGetSurfaceFeedback([](CZwpLinuxDmabufV1* r, uint32_t id, wl_resource* surf) { - const auto RESOURCE = PROTO::linuxDma->m_feedbacks.emplace_back( - makeShared(makeShared(r->client(), r->version(), id), CWLSurfaceResource::fromResource(surf))); + const auto& RESOURCE = PROTO::linuxDma->m_feedbacks.emplace_back( + makeUnique(makeUnique(r->client(), r->version(), id), CWLSurfaceResource::fromResource(surf))); if UNLIKELY (!RESOURCE->good()) { r->noMemory(); @@ -372,7 +373,7 @@ CLinuxDMABUFResource::CLinuxDMABUFResource(SP resource_) : m_ }); m_resource->setCreateParams([](CZwpLinuxDmabufV1* r, uint32_t id) { - const auto RESOURCE = PROTO::linuxDma->m_params.emplace_back(makeShared(makeShared(r->client(), r->version(), id))); + const auto& RESOURCE = PROTO::linuxDma->m_params.emplace_back(makeUnique(makeUnique(r->client(), r->version(), id))); if UNLIKELY (!RESOURCE->good()) { r->noMemory(); @@ -516,7 +517,7 @@ void CLinuxDMABufV1Protocol::resetFormatTable() { } void CLinuxDMABufV1Protocol::bindManager(wl_client* client, void* data, uint32_t ver, uint32_t id) { - const auto RESOURCE = m_managers.emplace_back(makeShared(makeShared(client, ver, id))); + const auto& RESOURCE = m_managers.emplace_back(makeUnique(makeUnique(client, ver, id))); if UNLIKELY (!RESOURCE->good()) { wl_client_post_no_memory(client); @@ -542,7 +543,7 @@ void CLinuxDMABufV1Protocol::destroyResource(CLinuxDMABuffer* resource) { } void CLinuxDMABufV1Protocol::updateScanoutTranche(SP surface, PHLMONITOR pMonitor) { - SP feedbackResource; + WP feedbackResource; for (auto const& f : m_feedbacks) { if (f->m_surface != surface) continue; diff --git a/src/protocols/LinuxDMABUF.hpp b/src/protocols/LinuxDMABUF.hpp index 7e8450e1f..ea2c9457b 100644 --- a/src/protocols/LinuxDMABUF.hpp +++ b/src/protocols/LinuxDMABUF.hpp @@ -59,7 +59,7 @@ class CDMABUFFormatTable { class CLinuxDMABUFParamsResource { public: - CLinuxDMABUFParamsResource(SP resource_); + CLinuxDMABUFParamsResource(UP&& resource_); ~CLinuxDMABUFParamsResource() = default; bool good(); @@ -70,7 +70,7 @@ class CLinuxDMABUFParamsResource { bool m_used = false; private: - SP m_resource; + UP m_resource; bool verify(); bool commence(); @@ -78,7 +78,7 @@ class CLinuxDMABUFParamsResource { class CLinuxDMABUFFeedbackResource { public: - CLinuxDMABUFFeedbackResource(SP resource_, SP surface_); + CLinuxDMABUFFeedbackResource(UP&& resource_, SP surface_); ~CLinuxDMABUFFeedbackResource() = default; bool good(); @@ -88,7 +88,7 @@ class CLinuxDMABUFFeedbackResource { SP m_surface; // optional, for surface feedbacks private: - SP m_resource; + UP m_resource; bool m_lastFeedbackWasScanout = false; friend class CLinuxDMABufV1Protocol; @@ -96,14 +96,14 @@ class CLinuxDMABUFFeedbackResource { class CLinuxDMABUFResource { public: - CLinuxDMABUFResource(SP resource_); + CLinuxDMABUFResource(UP&& resource_); ~CLinuxDMABUFResource() = default; bool good(); void sendMods(); private: - SP m_resource; + UP m_resource; }; class CLinuxDMABufV1Protocol : public IWaylandProtocol { @@ -123,10 +123,10 @@ class CLinuxDMABufV1Protocol : public IWaylandProtocol { void resetFormatTable(); // - std::vector> m_managers; - std::vector> m_feedbacks; - std::vector> m_params; - std::vector> m_buffers; + std::vector> m_managers; + std::vector> m_feedbacks; + std::vector> m_params; + std::vector> m_buffers; UP m_formatTable; dev_t m_mainDevice;