From 017a3c55d7bb2f23e50a534b13586590599b7ec2 Mon Sep 17 00:00:00 2001 From: Bukkit/Spigot Date: Thu, 25 Oct 2018 20:38:53 +1100 Subject: [PATCH] SPIGOT-4439: Allow minecraft:brand channel for use by plugins. By: md_5 --- .../src/main/java/org/bukkit/plugin/messaging/Messenger.java | 3 +++ .../java/org/bukkit/plugin/messaging/StandardMessenger.java | 2 +- .../org/bukkit/plugin/messaging/StandardMessengerTest.java | 1 + 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/paper-api/src/main/java/org/bukkit/plugin/messaging/Messenger.java b/paper-api/src/main/java/org/bukkit/plugin/messaging/Messenger.java index c9ef7e8469..7aa1d81ba7 100644 --- a/paper-api/src/main/java/org/bukkit/plugin/messaging/Messenger.java +++ b/paper-api/src/main/java/org/bukkit/plugin/messaging/Messenger.java @@ -27,6 +27,9 @@ public interface Messenger { /** * Checks if the specified channel is a reserved name. + *
+ * All channels within the "minecraft" namespace except for + * "minecraft:brand" are reserved. * * @param channel Channel name to check. * @return True if the channel is reserved, otherwise false. diff --git a/paper-api/src/main/java/org/bukkit/plugin/messaging/StandardMessenger.java b/paper-api/src/main/java/org/bukkit/plugin/messaging/StandardMessenger.java index 55a0360e4a..f21cae7202 100644 --- a/paper-api/src/main/java/org/bukkit/plugin/messaging/StandardMessenger.java +++ b/paper-api/src/main/java/org/bukkit/plugin/messaging/StandardMessenger.java @@ -170,7 +170,7 @@ public class StandardMessenger implements Messenger { public boolean isReservedChannel(String channel) { channel = validateAndCorrectChannel(channel); - return channel.contains("minecraft"); + return channel.contains("minecraft") && !channel.equals("minecraft:brand"); } public void registerOutgoingPluginChannel(Plugin plugin, String channel) { diff --git a/paper-api/src/test/java/org/bukkit/plugin/messaging/StandardMessengerTest.java b/paper-api/src/test/java/org/bukkit/plugin/messaging/StandardMessengerTest.java index cefbb0f959..c15fa0039e 100644 --- a/paper-api/src/test/java/org/bukkit/plugin/messaging/StandardMessengerTest.java +++ b/paper-api/src/test/java/org/bukkit/plugin/messaging/StandardMessengerTest.java @@ -27,6 +27,7 @@ public class StandardMessengerTest { assertTrue(messenger.isReservedChannel("minecraft:unregister")); assertFalse(messenger.isReservedChannel("test:nregister")); assertTrue(messenger.isReservedChannel("minecraft:something")); + assertFalse(messenger.isReservedChannel("minecraft:brand")); } @Test