twin/paper-mc
1
0
Fork 0
mirror of https://github.com/PaperMC/Paper.git synced 2025-08-08 16:12:18 -07:00
Code Issues Packages Projects Releases Wiki Activity

#686: Fix contains for default section generating real sections

Browse Source 
By: Wolf2323 <gabrielpatrikurban@gmail.com>
This commit is contained in:
Bukkit/Spigot
2021-12-04 22:05:54 +01:00
parent 3ddde21487
commit ab0429fddc
2 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
paper-api/src/main/java/org/bukkit/configuration/MemorySection.java
View File

@@ -251,10 +251,10 @@ public class MemorySection implements ConfigurationSection {
int i1 = -1, i2; int i1 = -1, i2;
ConfigurationSection section = this; ConfigurationSection section = this;
while ((i1 = path.indexOf(separator, i2 = i1 + 1)) != -1) { while ((i1 = path.indexOf(separator, i2 = i1 + 1)) != -1) {
section = section.getConfigurationSection(path.substring(i2, i1)); if (section == null || !section.contains(path.substring(i2, i1), true)) {
if (section == null) {
return def; return def;
} }
section = section.getConfigurationSection(path.substring(i2, i1));
} }
String key = path.substring(i2); String key = path.substring(i2);

10
paper-api/src/test/java/org/bukkit/configuration/ConfigurationSectionTest.java
View File

@@ -110,6 +110,16 @@ public abstract class ConfigurationSectionTest {
assertTrue(section.contains("doenst-exist-two", false)); assertTrue(section.contains("doenst-exist-two", false));
} }
@Test
public void testContainsDoesNotCreateSection() {
ConfigurationSection section = getConfigurationSection();
section.addDefault("notExistingSection.Value", "Test String");
assertFalse(section.contains("notExistingSection", true));
assertFalse(section.contains("notExistingSection.Value", true));
assertFalse(section.contains("notExistingSection", true));
}
@Test @Test
public void testIsSet() { public void testIsSet() {
ConfigurationSection section = getConfigurationSection(); ConfigurationSection section = getConfigurationSection();