twin/paper-mc
1
0
Fork 0
mirror of https://github.com/PaperMC/Paper.git synced 2025-08-25 01:13:53 -07:00
Code Issues Packages Projects Releases Wiki Activity

Enforce proper limits on books.

Browse Source 
By: md_5 <git@md-5.net>
This commit is contained in:
CraftBukkit/Spigot
2017-04-20 21:45:42 +10:00
parent 8d75072425
commit b690df1231
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
paper-server/src/main/java/org/bukkit/craftbukkit/inventory/CraftMetaBook.java
View File

@@ -29,8 +29,9 @@ public class CraftMetaBook extends CraftMetaItem implements BookMeta {
static final ItemMetaKey BOOK_PAGES = new ItemMetaKey("pages"); static final ItemMetaKey BOOK_PAGES = new ItemMetaKey("pages");
static final ItemMetaKey RESOLVED = new ItemMetaKey("resolved"); static final ItemMetaKey RESOLVED = new ItemMetaKey("resolved");
static final ItemMetaKey GENERATION = new ItemMetaKey("generation"); static final ItemMetaKey GENERATION = new ItemMetaKey("generation");
static final int MAX_PAGE_LENGTH = Short.MAX_VALUE; // TODO: Check me static final int MAX_PAGES = 50;
static final int MAX_TITLE_LENGTH = 0xffff; static final int MAX_PAGE_LENGTH = 256;
static final int MAX_TITLE_LENGTH = 16;
protected String title; protected String title;
protected String author; protected String author;
@@ -235,6 +236,10 @@ public class CraftMetaBook extends CraftMetaItem implements BookMeta {
public void addPage(final String... pages) { public void addPage(final String... pages) {
for (String page : pages) { for (String page : pages) {
if (this.pages.size() >= MAX_PAGES) {
return;
}
if (page == null) { if (page == null) {
page = ""; page = "";
} else if (page.length() > MAX_PAGE_LENGTH) { } else if (page.length() > MAX_PAGE_LENGTH) {