Begin implementation of CheckStyle style checking

By: md_5 <git@md-5.net>
This commit is contained in:
Bukkit/Spigot
2019-04-23 14:00:20 +10:00
parent 30a442aef7
commit c240b58f66
88 changed files with 246 additions and 192 deletions

View File

@@ -62,7 +62,7 @@ public class ChatColorTest {
assertThat(String.format("%c%c", ChatColor.COLOR_CHAR, color.getChar()), is(color.toString()));
}
}
@Test
public void translateAlternateColorCodes() {
String s = "&0&1&2&3&4&5&6&7&8&9&A&a&B&b&C&c&D&d&E&e&F&f&K&k & more";

View File

@@ -41,7 +41,7 @@ public class LocationTest {
@Parameters(name= "{index}: {0}")
public static List<Object[]> data() {
Random RANDOM = new Random(1l); // Test is deterministic
Random RANDOM = new Random(1L); // Test is deterministic
int r = 0;
return ImmutableList.<Object[]>of(
new Object[] { "X",

View File

@@ -12,7 +12,7 @@ import org.bukkit.plugin.SimplePluginManager;
import com.google.common.collect.ImmutableMap;
public class TestServer implements InvocationHandler {
public final class TestServer implements InvocationHandler {
private static interface MethodHandler {
Object handle(TestServer server, Object[] args);
}

View File

@@ -428,7 +428,7 @@ public abstract class ConfigurationSectionTest {
assertEquals(Arrays.asList((Object) true, false), section.getBooleanList(key));
assertEquals(Arrays.asList((Object) 4.0, 5.0, 6.0), section.getDoubleList(key));
assertEquals(Arrays.asList((Object) 4.0f, 5.0f, 6.0f), section.getFloatList(key));
assertEquals(Arrays.asList((Object) 4l, 5l, 6l), section.getLongList(key));
assertEquals(Arrays.asList((Object) 4L, 5L, 6L), section.getLongList(key));
assertEquals(Arrays.asList((Object) (byte) 4, (byte) 5, (byte) 6), section.getByteList(key));
assertEquals(Arrays.asList((Object) (short) 4, (short) 5, (short) 6), section.getShortList(key));
assertEquals(map, section.getMapList(key).get(0));
@@ -597,4 +597,4 @@ public abstract class ConfigurationSectionTest {
WORLD,
BANANAS
}
}
}

View File

@@ -153,4 +153,4 @@ public abstract class ConfigurationTest {
assertEquals(defaults, config.getDefaults());
}
}
}

View File

@@ -15,13 +15,13 @@ public class FakeConversable implements Conversable {
public Conversation begunConversation;
public Conversation abandonedConverstion;
public ConversationAbandonedEvent abandonedConversationEvent;
public boolean isConversing() {
return false;
return false;
}
public void acceptConversationInput(String input) {
}
public boolean beginConversation(Conversation conversation) {
@@ -40,66 +40,66 @@ public class FakeConversable implements Conversable {
}
public void sendRawMessage(String message) {
lastSentMessage = message;
lastSentMessage = message;
}
public Server getServer() {
return null;
return null;
}
public String getName() {
return null;
return null;
}
public boolean isPermissionSet(String name) {
return false;
return false;
}
public boolean isPermissionSet(Permission perm) {
return false;
return false;
}
public boolean hasPermission(String name) {
return false;
return false;
}
public boolean hasPermission(Permission perm) {
return false;
return false;
}
public PermissionAttachment addAttachment(Plugin plugin, String name, boolean value) {
return null;
return null;
}
public PermissionAttachment addAttachment(Plugin plugin) {
return null;
return null;
}
public PermissionAttachment addAttachment(Plugin plugin, String name, boolean value, int ticks) {
return null;
return null;
}
public PermissionAttachment addAttachment(Plugin plugin, int ticks) {
return null;
return null;
}
public void removeAttachment(PermissionAttachment attachment) {
}
public void recalculatePermissions() {
}
public Set<PermissionAttachmentInfo> getEffectivePermissions() {
return null;
return null;
}
public boolean isOp() {
return false;
return false;
}
public void setOp(boolean value) {
}
}

View File

@@ -18,7 +18,7 @@ public class ValidatingPromptTest {
prompt.acceptInput(null, "no");
assertFalse(prompt.result);
}
@Test
public void TestFixedSetPrompt() {
TestFixedSetPrompt prompt = new TestFixedSetPrompt("foo", "bar");
@@ -27,7 +27,7 @@ public class ValidatingPromptTest {
prompt.acceptInput(null, "foo");
assertEquals("foo", prompt.result);
}
@Test
public void TestNumericPrompt() {
TestNumericPrompt prompt = new TestNumericPrompt();
@@ -36,7 +36,7 @@ public class ValidatingPromptTest {
prompt.acceptInput(null, "1010220");
assertEquals(1010220, prompt.result);
}
@Test
public void TestRegexPrompt() {
TestRegexPrompt prompt = new TestRegexPrompt("a.c");
@@ -48,10 +48,10 @@ public class ValidatingPromptTest {
}
//TODO: TestPlayerNamePrompt()
private class TestBooleanPrompt extends BooleanPrompt {
public boolean result;
@Override
protected Prompt acceptValidatedInput(ConversationContext context, boolean input) {
result = input;
@@ -62,7 +62,7 @@ public class ValidatingPromptTest {
return null;
}
}
private class TestFixedSetPrompt extends FixedSetPrompt {
public String result;
@@ -80,10 +80,10 @@ public class ValidatingPromptTest {
return null;
}
}
private class TestNumericPrompt extends NumericPrompt {
public Number result;
@Override
protected Prompt acceptValidatedInput(ConversationContext context, Number input) {
result = input;

View File

@@ -30,7 +30,7 @@ public class SyntheticEventTest {
Assert.assertEquals(1, impl.callCount);
}
public static abstract class Base<E extends Event> implements Listener {
public abstract static class Base<E extends Event> implements Listener {
int callCount = 0;
public void accept(E evt) {

View File

@@ -34,7 +34,7 @@ public class MaterialDataTest {
assertThat("Constructed with default top or bottom",door.isTopHalf(),equalTo(false));
assertThat("Constructed with default direction",door.getFacing(),equalTo(BlockFace.WEST));
assertThat("Constructed with default open state",door.isOpen(),equalTo(false));
Material[] types = new Material[] { Material.LEGACY_WOODEN_DOOR,
Material.LEGACY_IRON_DOOR_BLOCK, Material.LEGACY_SPRUCE_DOOR,
Material.LEGACY_BIRCH_DOOR, Material.LEGACY_JUNGLE_DOOR,

View File

@@ -114,7 +114,7 @@ public class MetadataStoreTest {
assertEquals(1, subject.getMetadata("subject", "key").size());
assertEquals(10, subject.getMetadata("subject", "key").get(0).value());
}
@Test
public void testHasMetadata() {
subject.setMetadata("subject", "key", new FixedMetadataValue(pluginX, 10));

View File

@@ -13,7 +13,7 @@ import org.bukkit.generator.ChunkGenerator;
public class TestPlugin extends PluginBase {
private boolean enabled = true;
final private String pluginName;
private final String pluginName;
public TestPlugin(String pluginName) {
this.pluginName = pluginName;

View File

@@ -9,7 +9,7 @@ import java.util.HashMap;
import org.bukkit.entity.Player;
public class TestPlayer implements InvocationHandler {
public final class TestPlayer implements InvocationHandler {
private static interface MethodHandler {
Object handle(TestPlayer server, Object[] args);
}