mirror of
https://github.com/BurntSushi/ripgrep.git
synced 2025-07-25 17:21:57 -07:00
ignore: treat symbolic links to directories as directories
Due to how walkdir works if symlinks are not followed, symlinks to directories are seen as simple files by ripgrep. This caused a panic in some cases due to receiving a WalkEvent::Exit event without a corresponding WalkEvent::Dir event. This is fixed by looking at the metadata of the file in the case of a symlink to determine if it's a directory. We are careful to only do this stat check when the depth of the entry is 0, as this bug only impacts us when 1) we aren't following symlinks generally and 2) the user provides a symlinked directory that we do follow as a top-level path to search. Fixes #1389, Closes #1397
This commit is contained in:
@@ -747,6 +747,21 @@ rgtest!(r1334_crazy_literals, |dir: Dir, mut cmd: TestCommand| {
|
||||
);
|
||||
});
|
||||
|
||||
// See: https://github.com/BurntSushi/ripgrep/issues/1389
|
||||
rgtest!(r1389_bad_symlinks_no_biscuit, |dir: Dir, mut cmd: TestCommand| {
|
||||
dir.create_dir("mydir");
|
||||
dir.create("mydir/file.txt", "test");
|
||||
dir.link_dir("mydir", "mylink");
|
||||
|
||||
let stdout = cmd.args(&[
|
||||
"test",
|
||||
"--no-ignore",
|
||||
"--sort", "path",
|
||||
"mylink",
|
||||
]).stdout();
|
||||
eqnice!("mylink/file.txt:test\n", stdout);
|
||||
});
|
||||
|
||||
// See: https://github.com/BurntSushi/ripgrep/pull/1446
|
||||
rgtest!(r1446_respect_excludes_in_worktree, |dir: Dir, mut cmd: TestCommand| {
|
||||
dir.create_dir("repo/.git/info");
|
||||
|
Reference in New Issue
Block a user