twin/ripgrep
1
0
Fork 0
mirror of https://github.com/BurntSushi/ripgrep.git synced 2025-05-19 09:40:22 -07:00
Code Issues Packages Projects Releases Wiki Activity

benchsuite: fix bugs

Browse Source 
This fixes a few bugs in the benchsuite script that have apparently
cropped up over time due to insufficient testing.

Fixes #558
This commit is contained in:
Andrew Gallant 2017-07-17 08:21:42 -04:00
parent 0668c74ed4
commit bfbd53eb92
No known key found for this signature in database
GPG Key ID: B2E3A4923F8B0D44
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
benchsuite/benchsuite
View File

@ -1082,7 +1082,7 @@ def download_subtitles_en(suite_dir):
if not os.path.exists(en_path): if not os.path.exists(en_path):
if not os.path.exists(en_path_gz): if not os.path.exists(en_path_gz):
run_cmd(['curl', '-LO', SUBTITLES_EN_URL], cwd=subtitle_dir) run_cmd(['curl', '-LO', SUBTITLES_EN_URL], cwd=subtitle_dir)
run_cmd(['gunzip', en_path_gz], cwd=subtitle_dir) run_cmd(['gunzip', en_path_gz])
if not os.path.exists(en_path_sample): if not os.path.exists(en_path_sample):
# Get a sample roughly the same size as the Russian corpus so that # Get a sample roughly the same size as the Russian corpus so that
# benchmarks finish in a reasonable time. # benchmarks finish in a reasonable time.
@ -1109,7 +1109,7 @@ def download_subtitles_ru(suite_dir):
if not os.path.exists(ru_path): if not os.path.exists(ru_path):
if not os.path.exists(ru_path_gz): if not os.path.exists(ru_path_gz):
run_cmd(['curl', '-LO', SUBTITLES_RU_URL], cwd=subtitle_dir) run_cmd(['curl', '-LO', SUBTITLES_RU_URL], cwd=subtitle_dir)
run_cmd(['gunzip', ru_path_gz], cwd=subtitle_dir) run_cmd(['gunzip', ru_path_gz])
def has_subtitles_ru(suite_dir): def has_subtitles_ru(suite_dir):
@ -1184,6 +1184,7 @@ def collect_benchmarks(suite_dir, filter_pat=None,
name, name,
' '.join(['--download %s' % n for n in e.missing_names]), ' '.join(['--download %s' % n for n in e.missing_names]),
)) ))
continue
except MissingCommands as e: except MissingCommands as e:
fmt = 'missing commands: %s, skipping benchmark %s ' \ fmt = 'missing commands: %s, skipping benchmark %s ' \
'(run with --allow-missing to run incomplete benchmarks)' '(run with --allow-missing to run incomplete benchmarks)'
@ -1239,7 +1240,7 @@ def main():
benchmarks = collect_benchmarks( benchmarks = collect_benchmarks(
args.dir, filter_pat=args.bench, args.dir, filter_pat=args.bench,
allow_missing_commands=args.allow_missing, allow_missing_commands=args.allow_missing,
disabled_cmds=args.disabled.split(','), disabled_cmds=(args.disabled or '').split(','),
warmup_iter=args.warmup_iter, bench_iter=args.bench_iter) warmup_iter=args.warmup_iter, bench_iter=args.bench_iter)
for b in benchmarks: for b in benchmarks:
print(b.name) print(b.name)