From d06f84ced349b97a5181abf5d9e3029e18ee2b1c Mon Sep 17 00:00:00 2001 From: Andrew Gallant Date: Sun, 20 Nov 2016 15:32:50 -0500 Subject: [PATCH] Get rid of special mmap decision on Windows. I spent some quality time on my Windows 10 laptop and it appears to suffer from a similar trade-off as on Linux: mmaps are bad for large directory traversals but good for single large files. Darwin continues to reject memory maps in all cases (unless explicitly requested), but more testing should be done there. --- src/args.rs | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/args.rs b/src/args.rs index aa8f2764..77421c4b 100644 --- a/src/args.rs +++ b/src/args.rs @@ -504,9 +504,6 @@ impl<'a> ArgMatches<'a> { false } else if self.is_present("mmap") { true - } else if cfg!(windows) { - // On Windows, memory maps appear faster than read calls. Neat. - true } else if cfg!(target_os = "macos") { // On Mac, memory maps appear to suck. Neat. false