twin/xmonad-contrib
1
0
Fork 0
mirror of https://github.com/xmonad/xmonad-contrib.git synced 2025-05-19 11:30:22 -07:00
Code Issues Packages Projects Releases Wiki Activity

X.H.ManageDocks: Fix button events on decoration windows

Browse Source 
Decoration windows are created using XMonad.Util.XUtils.createNewWindow
which happens to set _NET_WM_WINDOW_TYPE to _NET_WM_WINDOW_TYPE_DESKTOP,
and ManageDocks considers such windows candidates for struts and
therefore requests property events, thus overriding the original event
mask requested by decorations.

The fix is to first obtain the current event mask, set the required bits
in it only then reset the mask.

Fixes: https://github.com/xmonad/xmonad-contrib/issues/517
Fixes: ec146171238b ("X.H.ManageDocks: React to strut updates of override_redirect docks")
Related: https://github.com/xmonad/X11/pull/77
This commit is contained in:
Tomas Janousek 2021-05-14 18:32:45 +01:00
parent 1427c9484a
commit 56cf96cfa9
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
XMonad/Hooks/ManageDocks.hs
View File

@ -142,7 +142,8 @@ manageDocks = checkDock --> (doIgnore <+> doRequestDockEvents)
-- (Only if not already a client to avoid overriding 'clientMask') -- (Only if not already a client to avoid overriding 'clientMask')
requestDockEvents :: Window -> X () requestDockEvents :: Window -> X ()
requestDockEvents w = whenX (not <$> isClient w) $ withDisplay $ \dpy -> requestDockEvents w = whenX (not <$> isClient w) $ withDisplay $ \dpy ->
io $ selectInput dpy w (propertyChangeMask .|. structureNotifyMask) withWindowAttributes dpy w $ \attrs -> io $ selectInput dpy w $
wa_your_event_mask attrs .|. propertyChangeMask .|. structureNotifyMask
-- | Checks if a window is a DOCK or DESKTOP window -- | Checks if a window is a DOCK or DESKTOP window
checkDock :: Query Bool checkDock :: Query Bool