From 4badaa45edd0188d21c62ca70bd9aadc865f6d18 Mon Sep 17 00:00:00 2001 From: slotThe Date: Sat, 1 May 2021 11:19:20 +0200 Subject: [PATCH 1/2] Update issue template - We would really like a full template and not just a snippet where we'll have to guess the context. - It's generally nice to know which versions of xmonad and contrib a users was using when encountering an issue. --- .github/ISSUE_TEMPLATE.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index e53286a1..812b81ea 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -9,8 +9,8 @@ Give detailed step-by-step instructions on how to reproduce the problem. ### Configuration File -Please include the smallest configuration file that reproduces the -problem you are experiencing: +Please include the smallest _full_ configuration file that reproduces +the problem you are experiencing: ```haskell module Main (main) where @@ -25,4 +25,6 @@ main = xmonad def - [ ] I've read [CONTRIBUTING.md](https://github.com/xmonad/xmonad/blob/master/CONTRIBUTING.md) - - [ ] I tested my configuration with [xmonad-testing](https://github.com/xmonad/xmonad-testing) + - I tested my configuration + - [ ] With `xmonad` version XXX (commit XXX if using git) + - [ ] With `xmonad-contrib` version XXX (commit XXX if using git) From 4815c424824880d233c1ea59f15b97582624ac88 Mon Sep 17 00:00:00 2001 From: slotThe Date: Sat, 1 May 2021 11:23:29 +0200 Subject: [PATCH 2/2] Change xmonad-testing box to question about tests I don't think I've ever seen anyone check that mark, so let's transform it into something more useful. --- .github/PULL_REQUEST_TEMPLATE.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 8b613637..99bd30ad 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -7,7 +7,8 @@ behind them. - [ ] I've read [CONTRIBUTING.md](https://github.com/xmonad/xmonad/blob/master/CONTRIBUTING.md) - - [ ] I tested my changes with [xmonad-testing](https://github.com/xmonad/xmonad-testing) + - [ ] I've considered how to best test these changes (property, unit, + manually, ...) and concluded: XXX - [ ] I updated the `CHANGES.md` file