From cadb178819fa70b7fc83c69399c11030491de8b9 Mon Sep 17 00:00:00 2001 From: Ivan Malison Date: Mon, 23 Aug 2021 21:03:41 -0600 Subject: [PATCH] Undeprecate spacing convenience functions These should be undeprecated for several reasons: - The suggestion to use spacingRaw is pretty ridiculous; the interface to spacingRaw is very general and flexible, which is great, but I think that most people probably do not need all of that flexibility, and one of these convenience functions may suit their needs better. - There is precendent for having convenience functions like these (like X.L.Magnifier) These were deprecated in a rewrite to make X.L.Spacing support a non-uniform border length, but from a usability perspective wrappers should always be preferred to such a general interface with rather shaky documentation. Related: https://github.com/xmonad/xmonad-contrib/pull/243 (2c53d507ee6c49ab053e17fff0a2149087df3292) --- XMonad/Layout/Spacing.hs | 5 ----- 1 file changed, 5 deletions(-) diff --git a/XMonad/Layout/Spacing.hs b/XMonad/Layout/Spacing.hs index 0990150e..9f67d178 100644 --- a/XMonad/Layout/Spacing.hs +++ b/XMonad/Layout/Spacing.hs @@ -329,14 +329,9 @@ orderSelect o (lt,eq,gt) = case o of ----------------------------------------------------------------------------- {-# DEPRECATED SpacingWithEdge, SmartSpacing, SmartSpacingWithEdge "Use Spacing instead." #-} {-# DEPRECATED ModifySpacing "Use SpacingModifier instead, perhaps with sendMessages." #-} -{-# DEPRECATED spacing, spacingWithEdge, smartSpacing, smartSpacingWithEdge "Use spacingRaw instead." #-} {-# DEPRECATED setSpacing "Use setScreenWindowSpacing instead." #-} {-# DEPRECATED incSpacing "Use incScreenWindowSpacing instead." #-} --- $backwardsCompatibility --- The following functions and types exist solely for compatibility with --- pre-0.14 releases. - -- | A type synonym for the 'Spacing' 'LayoutModifier'. type SpacingWithEdge = Spacing