twin/xmonad-contrib
1
0
Fork 0
mirror of https://github.com/xmonad/xmonad-contrib.git synced 2025-07-26 09:41:52 -07:00
Code Issues Packages Projects Releases Wiki Activity

XSelection: getSelection: fix connection exhaustion bug (issue #573); include warning

Browse Source
This commit is contained in:
gwern
2014-06-01 02:50:19 +00:00
parent 72a537cf46
commit eca9d7318e
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
XMonad/Util/XSelection.hs
View File

@@ -46,6 +46,10 @@ import Codec.Binary.UTF8.String (decode)
-- | Returns a String corresponding to the current mouse selection in X; -- | Returns a String corresponding to the current mouse selection in X;
-- if there is none, an empty string is returned. -- if there is none, an empty string is returned.
--
-- WARNING: this function is fundamentally implemented incorrectly and may, among other possible failure modes,
-- deadlock or crash. For details, see <http://code.google.com/p/xmonad/issues/detail?id=573>.
-- (These errors are generally very rare in practice, but still exist.)
getSelection :: MonadIO m => m String getSelection :: MonadIO m => m String
getSelection = io $ do getSelection = io $ do
dpy <- openDisplay "" dpy <- openDisplay ""
@@ -63,10 +67,12 @@ getSelection = io $ do
allocaXEvent $ \e -> do allocaXEvent $ \e -> do
nextEvent dpy e nextEvent dpy e
ev <- getEvent e ev <- getEvent e
if ev_event_type ev == selectionNotify result <- if ev_event_type ev == selectionNotify
then do res <- getWindowProperty8 dpy clp win then do res <- getWindowProperty8 dpy clp win
return $ decode . map fromIntegral . fromMaybe [] $ res return $ decode . map fromIntegral . fromMaybe [] $ res
else destroyWindow dpy win >> return "" else destroyWindow dpy win >> return ""
closeDisplay dpy
return result
{- | A wrapper around 'getSelection'. Makes it convenient to run a program with the current selection as an argument. {- | A wrapper around 'getSelection'. Makes it convenient to run a program with the current selection as an argument.
This is convenient for handling URLs, in particular. For example, in your Config.hs you could bind a key to This is convenient for handling URLs, in particular. For example, in your Config.hs you could bind a key to