twin/xmonad
1
0
Fork 0
mirror of https://github.com/xmonad/xmonad.git synced 2025-05-19 08:30:21 -07:00
Code Issues Packages Projects Releases Wiki Activity

CONTRIBUTING: Drop xmonad-testing

Browse Source 
xmonad-testing isn't really being used, so the wording needs to be
changed in CONTRIBUTING.md and in the PR template. The important thing:
we want an example for new modules/functionality, and appropriate tests.

Related: https://github.com/xmonad/xmonad/issues/341
This commit is contained in:
Yecine Megdiche 2021-10-26 09:53:05 +02:00 committed by Tomas Janousek
parent 72794d92b1
commit 78f1a8e716
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.github/PULL_REQUEST_TEMPLATE.md vendored
View File

@ -9,6 +9,7 @@ behind them.
- [ ] I've confirmed these changes don't belong in xmonad-contrib instead - [ ] I've confirmed these changes don't belong in xmonad-contrib instead
- [ ] I tested my changes with [xmonad-testing](https://github.com/xmonad/xmonad-testing) - [ ] I've considered how to best test these changes (property, unit,
manually, ...) and concluded: XXX
- [ ] I updated the `CHANGES.md` file - [ ] I updated the `CHANGES.md` file

7
CONTRIBUTING.md
View File

@ -61,9 +61,10 @@ Here are some tips for getting your changes merged into xmonad:
* Your changes should include relevant entries in the `CHANGES.md` * Your changes should include relevant entries in the `CHANGES.md`
file. Help us communicate changes to the community. file. Help us communicate changes to the community.
* Make sure you test your changes using the [xmonad-testing][] * Make sure you test your changes against the most recent commit of
repository. Include a new configuration file that shows off your [xmonad][] (and [xmonad-contrib][], if you're contributing there).
changes if possible by creating a PR on that repository as well. If you're adding a new module or functionality, make sure to add an
example in the documentation and in the PR description.
* Make sure you run the automated tests. Both [xmonad-contrib][] * Make sure you run the automated tests. Both [xmonad-contrib][]
and [xmonad][] have test-suites that you could run with and [xmonad][] have test-suites that you could run with